Generation 3 had some of the best pokemon ever: Sableye, Spinda, Mawile, Blaziken, Grovyle, Mudkipz, Tropius, Manectric, Walrein, Torkoal, Wiscash, most of them, actually.
Generation 4 had decent pokemon, none I particularly love. Though I don't see why people hate Probopass. He's like Mr...