Wow. Where to start with this one? I love Game Theory, but this is the first one I have to completely disagree with you. The primary problem is that this theory glosses over so many finer points. Jack wanted to save millions on Elpis? My read on that has always been that those millions of lives saved were in fact merely a side benefit of Jack's true goal, saving Elpis' vault from being destroyed and kept from him (my read of the story was also that Zarpedon was far more of a hero than Jack, willing to sacrifice millions, and herself, to save far more down the road). Jack wants to make Pandora a paradise? Sure, by slaughtering ANYONE he deems unfit for his new paradise, regardless of who they are or what they've done, meaning millions will die as he scours the world of undesirables to make way for his gleaming paradise.
One of the primary themes of Borderlands 2 was of imperialism, and how imperialists think they have the locals' best interests at heart, but in fact they are greedy, megalomaniacs who want to impose their values on others, no matter how much pain and death they cause in doing so. Jack is the ultimate imperialist, wishing to purge the world, killing millions to make the world "safe".
I also would argue that we do not know Jack saw his death in the visions in the vault. In fact, given the fragmented way in which the vision is presented and the fact that no such visions of his death are ever even shown, it seems likely that he did not see it, instead merely seeing what the vault contained, i.e. the Warrior.
The Pre-Sequel was not a game about Jack moving from hero to villain. I see him as a villain when the game starts. This is a man who might have some altruistic ideas, but has already enslaved his own daughter, manipulated the original vault hunters into opening the original vault so that Jack could get at both the Destroyer and the Eriudium so that he could take control of them, all for his own gain and twisted vision of order and stability. During the game, he murders several of his own scientists, just because someone mentioned offhand that one of them could, in theory, possibly, be a spy. He has created a planet destroying super weapon, killed an AI that was begging for her life, and afterwards he was interested only in the product of this most recent murder and THE FREAKING COLOR OF HIS NEW ROBOT.
In fact, now that I think about it, Jack's reaction to the murder of Felicity is a perfect representation of how Jack views... everyone. Resources to be used and modified as he sees fit. Just look at Opportunity. His gleaming utopia on the horizon, allowing on the best in, and even then only so that they can populate what amounts to a shrine to Jack. Opportunity does not exist so that people can have a nice place to live. It exists so that people that Jack approves of can go there and worship him.
I'm going to wrap this up rather than write a thesis, but I do believe I could make a fairly extensive piece on how Jack is every imperialist our world has ever had that has slaughtered their way through natives in the name of PROGRESS. Jack is not a hero. That is falling for his hype. Pandora is a lawless, chaotic place, but there is no warranting the murder of innocents, slavery and segregation so that one man can attempt to become a god and build a world in his own image.