For me the best controllers had to be the Xbox NeoS (with the exception of the white and black button placement) and the 360 controller (with the exception of the D-pad). The design is close to perfect for me and ergonomically fits me very well. I'm also fond of the SNES, Dreamcast and N64 controllers.
The worst: Every iteration of the Playstation controller, they feel really bad in my hands, the analogue sticks feel too loose, they're too light, I dislike the face button scheme (saying triangle, x, circle, square is more awkward than a,b,x,y, or even just colours). I also really didn't like the Gamecube controller, it felt like a cheap plastic toy and the analogue stick was particularly dreadful as well. Lots of third party crap.
The worst: Every iteration of the Playstation controller, they feel really bad in my hands, the analogue sticks feel too loose, they're too light, I dislike the face button scheme (saying triangle, x, circle, square is more awkward than a,b,x,y, or even just colours). I also really didn't like the Gamecube controller, it felt like a cheap plastic toy and the analogue stick was particularly dreadful as well. Lots of third party crap.