I think the gamecube controller, ugly as it is, is the best controller I've ever held in my hands. Beginners never have to look down because every button feels different and is placed intuitively on the controller.
In contrast, I think the dual shock is the worst controller, at least since 3D gaming (that's polygons, not the 3D glasses revival going on) came along. Four shoulder buttons that feel exactly alike and are clumsily placed? Four buttons for your right thumb that all feel the exact same, and are named triangle square circle and "x"? Seriously? That's supposed to be intuitive? Microsoft is pretty bad too, as they tend to splash buttons all over the right half of the controller, but the dual shock is the least ergonomic and in my opinion the least intuitive controller of the "modern" era, and it's not really changed at all, either.
Move wins the title of ugliest, however. It looks like it was built by a LARP'er in a used electronics store, and the stupid sphere shows up on the screen when you're using it to play a shooter.